Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tss2-sys when generating bindings too #227

Merged
merged 1 commit into from
May 7, 2021

Conversation

ionut-arm
Copy link
Member

The tss2-sys is only being linked to explicitly when the bindings are
not generated, after #226. This fixes that discrepancy.

Signed-off-by: Ionut Mihalcea [email protected]

The tss2-sys is only being linked to explicitly when the bindings are
not generated, after parallaxsecond#226. This fixes that discrepancy.

Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm ionut-arm added the bug Something isn't working label May 6, 2021
@ionut-arm ionut-arm self-assigned this May 6, 2021
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In here maybe we should indicate every lib that we link to

@ionut-arm
Copy link
Member Author

In here maybe we should indicate every lib that we link to

It's a bit problematic, because that field is made for one value, see doc. They say here there should be at most one package per links value, but I think it's the other way around as well.

@hug-dev
Copy link
Member

hug-dev commented May 6, 2021

Ah true, I think actually we discussed that in the post and said that maybe ideally there should be one -sys crate per lib. I guess this is fine to leave that for now.

@ionut-arm ionut-arm enabled auto-merge May 6, 2021 15:30
@Superhepper
Copy link
Collaborator

Why is it only sys? Why is it not needed to link against each individual library in the software stack?

@ionut-arm
Copy link
Member Author

Why is it only sys? Why is it not needed to link against each individual library in the software stack?

I'm not entirely sure, the problem only appeared when I tried to cross-compile Parsec - for some reason doing the same thing that we do in the cross-compilation tests for this crate doesn't work, it complains that the symbols in tss2-sys can't be found. I worry that if I ignore it and just link "by hand" to the library in the Parsec builds, every user of this crate might have to do the same for their binaries.

@ionut-arm ionut-arm merged commit 56c487a into parallaxsecond:main May 7, 2021
@ionut-arm ionut-arm deleted the link-sys-2 branch May 7, 2021 08:43
tgonzalezorlandoarm pushed a commit to tgonzalezorlandoarm/rust-tss-esapi that referenced this pull request Mar 14, 2024
Update attribute handling in PKCS11 provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants