-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tss2-sys when generating bindings too #227
Conversation
The tss2-sys is only being linked to explicitly when the bindings are not generated, after parallaxsecond#226. This fixes that discrepancy. Signed-off-by: Ionut Mihalcea <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In here maybe we should indicate every lib that we link to
Ah true, I think actually we discussed that in the post and said that maybe ideally there should be one |
Why is it only sys? Why is it not needed to link against each individual library in the software stack? |
I'm not entirely sure, the problem only appeared when I tried to cross-compile Parsec - for some reason doing the same thing that we do in the cross-compilation tests for this crate doesn't work, it complains that the symbols in |
Update attribute handling in PKCS11 provider
The tss2-sys is only being linked to explicitly when the bindings are
not generated, after #226. This fixes that discrepancy.
Signed-off-by: Ionut Mihalcea [email protected]