-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for getting attribute info - #42 #48
Updates for getting attribute info - #42 #48
Conversation
- Updated comment for `get_attribute_info` - Added `get_attribute_info_map` - Added `get_single_attribute_info` - Added `Hash` derivation for `AttributeType` Signed-off-by: Michael J Boquard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few more ideas...
- Updated `AttributeInfo` to include `Sensitive` and `TypeInvalid` variants - Removed `Unavailable` variant from `AttributeInfo` - Updated `get_attribute_info` to step through each attribute - Removed `get_single_attribute_info` Signed-off-by: Michael J Boquard <[email protected]>
4dd3fe6
to
89e015c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
- Updated function comments - Fixed some warnings generated by the docs Signed-off-by: Michael J Boquard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
get_attribute_info
get_attribute_info_map
get_single_attribute_info
Hash
derivation forAttributeType
Signed-off-by: Michael J Boquard [email protected]