Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to Rust 1.66.0 #692

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

tgonzalezorlandoarm
Copy link
Member

@tgonzalezorlandoarm tgonzalezorlandoarm commented Aug 21, 2023

As RHEL-9 has Rust Toolchain 1.66.1 now, it is possible to update the CI MSRV to Rust 1.66.0

@tgonzalezorlandoarm tgonzalezorlandoarm marked this pull request as ready for review August 21, 2023 18:17
@tgonzalezorlandoarm tgonzalezorlandoarm requested a review from a team as a code owner August 21, 2023 18:17
@tgonzalezorlandoarm tgonzalezorlandoarm changed the title Draft: Update MSRV to Rust 1.60 Update MSRV to Rust 1.60 Aug 21, 2023
Signed-off-by: Tomás González <[email protected]>
@tgonzalezorlandoarm tgonzalezorlandoarm changed the title Update MSRV to Rust 1.60 Update MSRV to Rust 1.66.0 Aug 22, 2023
@ionut-arm
Copy link
Member

The nightly run failed, but it seems it's because of a test, not because of the build steps.

@tgonzalezorlandoarm
Copy link
Member Author

Let's get this one in first and then I'll take care of the test error in a separate PR?

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ionut-arm ionut-arm merged commit 5105861 into parallaxsecond:main Aug 22, 2023
13 checks passed
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/update-msrv branch September 1, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants