Make buffers dynamically sized in Mbed Provider #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hug-dev
reviewed
Oct 29, 2019
| } | ||
|
|
||
| /// Compute the size of the asymmetric signature, given the key attributes of the signing key. | ||
| pub fn psa_asymmetric_sign_output_size(key_attrs: &psa_key_attributes_t) -> Result<usize> { |
There was a problem hiding this comment.
Maybe it would be nice to add where do those functions come from? Something like which C file, which macro are they implementing? It would help for maintaining in the future I think.
This commit makes the sizes of buffers used by the mbed provider dynamic, computed at runtime based on key attributes, the same way that mbed crypto calculates them. Signed-off-by: Ionut Mihalcea <[email protected]>
ionut-arm
force-pushed
the
buffer_size
branch
from
07741c6
to
468616f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer sizes are now dynamically computed based on the macros provided in
crypto_sizes.h.Resolves #27