Remove references to key lifetime #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it makes sense to keep this consistently versioned so yeah, |
ionut-arm
approved these changes
Oct 23, 2019
| @@ -157,7 +157,6 @@ pub const PSA_ALG_KEY_DERIVATION_MASK: psa_algorithm_t = 0x010f_ffff; | |||
| pub const PSA_ALG_SELECT_RAW: psa_algorithm_t = 0x3100_0001; | |||
| pub const PSA_ALG_FFDH_BASE: psa_algorithm_t = 0x2210_0000; | |||
| pub const PSA_ALG_ECDH_BASE: psa_algorithm_t = 0x2220_0000; | |||
| pub const PSA_KEY_LIFETIME_VOLATILE: psa_key_lifetime_t = 0x0000_0000; | |||
There was a problem hiding this comment.
Just as a sidenote, this could've been kept - definitely not all the constants defined here are actually used; maybe in the future we'll end up supporting volatile keys somehow, but this can go as is.
Changes needed after they were removed from parallaxsecond/parsec-interface-rs#5. Signed-off-by: Hugues de Valon <[email protected]>
hug-dev
force-pushed
the
remove-lifetimes
branch
from
89b4fff
to
759dd98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed after they were removed from
parallaxsecond/parsec-interface-rs#5.
Will need changes in
Cargo.tomlfile to pull the newer version ofparsec-interface-rs.@ionut-arm Should it be
0.2.0as well?