Added provider names to the config. #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattDavis00
force-pushed
the
feature-provider-names
branch
from
2eba599
to
40c3e6b
Compare
ionut-arm
reviewed
Jul 28, 2021
hug-dev
reviewed
Jul 29, 2021
MattDavis00
force-pushed
the
feature-provider-names
branch
5 times, most recently
from
de3c267
to
38e1f20
Compare
ionut-arm
approved these changes
Jul 29, 2021
hug-dev
reviewed
Jul 29, 2021
There was a problem hiding this comment.
Since you are doing all the work on a separate feature branch, this is totally fine to merge things little by little. I think it would be nice to have in a future PR some config tests:
- checking that the service starts with multiple providers of the same type with different names
- checking that the service fails to start with multiple providers of the same type with the default name
- creating a key with a provider of type A then restarting the service with a configuration where a new provider of the type A is added but check that the key can still be accessed
MattDavis00
force-pushed
the
feature-provider-names
branch
from
38e1f20
to
0874637
Compare
This is an optional field, and will default to a suitable name for each provider if it is not provided. Two providers cannot have the same name. Closes parallaxsecond#487 Signed-off-by: Matt Davis <[email protected]>
MattDavis00
force-pushed
the
feature-provider-names
branch
from
0874637
to
8632fef
Compare
hug-dev
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional field and defaults to a suitable name for each provider if it is not provided.
Two providers cannot have the same name.
Closes #487
Signed-off-by: Matt Davis [email protected]