[CryptoAuthLib provider] Support for psa_sign_message and psa_verify_message. #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plenty of small transitions from ProviderID to ProviderId. Corrections of formatting in e2e-tests. Signed-off-by: Robert Drazkowski <[email protected]>
ionut-arm
reviewed
May 17, 2021
Comment on lines
86
to
88
| if op.hash.len() != rust_cryptoauthlib::ATCA_SHA2_256_DIGEST_SIZE { | ||
| return Err(ResponseStatus::PsaErrorInvalidArgument); | ||
| } |
There was a problem hiding this comment.
Would it be helpful to do this check in psa_verify_hash_internal as well?
There was a problem hiding this comment.
Done, with some minor improvements.
Input parameter handling improvements in sign operations. Signed-off-by: Robert Drazkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for psa_sign_message and psa_verify_message.
Plenty of small transitions from ProviderID to ProviderId.
Corrections of formatting in e2e-tests.