Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all dependencies to their latest version #345

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Feb 22, 2021

Also fix some recent clippy errors (but not on the PKCS11 provider which
might change soon).

@hug-dev hug-dev force-pushed the upgrade-deps branch 2 times, most recently from 509c4f2 to d5ea708 Compare February 22, 2021 12:39
@@ -74,7 +75,7 @@ impl DomainSocketListener {
let nfd = sd_notify::SD_LISTEN_FDS_START;
// Safe as listen_fds gives us the information that one file descriptor was
// received and its value starts from SD_LISTEN_FDS_START.
unsafe { UnixListener::from_raw_fd(nfd) }
unsafe { UnixListener::from_raw_fd(nfd.try_into()?) }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix some recent clippy errors (but not on the PKCS11 provider which
might change soon).

Signed-off-by: Hugues de Valon <[email protected]>
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I've duplicated some of your changes brought by clippy.

Which also makes me think that we should make the nightly run include at least the clippy part and some of the E2E tests

@hug-dev hug-dev merged commit 52458f7 into parallaxsecond:master Feb 22, 2021
@hug-dev hug-dev deleted the upgrade-deps branch February 22, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants