Add buffer_size_limit config option for providers
#233
Conversation
joechrisellis
force-pushed
the
add_buffer_size_limit
branch
from
a8f1cc9
to
a801195
Compare
joechrisellis
force-pushed
the
add_buffer_size_limit
branch
from
a801195
to
647cbe6
Compare
| @@ -53,6 +53,9 @@ const WIRE_PROTOCOL_VERSION_MAJOR: u8 = 1; | |||
| /// Default value for the limit on the request body size (in bytes) - equal to 1MB | |||
| const DEFAULT_BODY_LEN_LIMIT: usize = 1 << 19; | |||
There was a problem hiding this comment.
We should probably fix this one as well 👀
There was a problem hiding this comment.
Yeah, was going to do that in a separate patch. Let me do that now...
config.toml
Outdated
| @@ -64,10 +64,15 @@ provider_type = "MbedCrypto" | |||
| # (Required) Name of key info manager that will support this provider. | |||
| key_info_manager = "on-disk-manager" | |||
|
|
|||
| # (Optional) Decide how large (in bytes) buffers inside responses from this provider can be. | |||
| # Requests that ask for buffers larger than this threshold will be rejected. Defaults to 1MB. | |||
| #buffer_size_limit = 1048576 | |||
There was a problem hiding this comment.
I think for this option it is fine if we only have one global config option declared in the core_settings and that work for all the service.
That way, you just have to add the option to the GlobalConfig and access it from there directly when you need it 💯
There was a problem hiding this comment.
I thought it might be a good idea to have a separate one for each provider in case the provider itself has specific limitations that we might want to accommodate for. Although thinking about it, I can't really come up with anything concrete off the top of my head. I'll change this.
There was a problem hiding this comment.
I guess as all providers are running with the same allocated memory, that's fine to assume that they would all have similar limitations! Also, did not want to increase the configuration complexity for such a small feature 😋
joechrisellis
force-pushed
the
add_buffer_size_limit
branch
2 times, most recently
from
849f375
to
8a48384
Compare
The buffer size limit can be used to cap the maximum allowed buffer size sent in a response. Requests that ask for buffers larger than this value will be automatically rejected. Signed-off-by: Joe Ellis <[email protected]>
joechrisellis
force-pushed
the
add_buffer_size_limit
branch
from
8a48384
to
7d6c148
Compare
The buffer size limit can be used to cap the maximum allowed buffer size
sent in a response. Requests that ask for buffers larger than this value
will be automatically rejected.