Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PKCS#11 provieder failing failed_created_key_should_be_removed test #188

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Fixed PKCS#11 provieder failing failed_created_key_should_be_removed test #188

merged 1 commit into from
Jun 19, 2020

Conversation

sbailey-arm
Copy link
Contributor

PKCS#11 provider wasn't removing the key ID from the key ID store on two possible failure paths.

Signed-off-by: Samuel Bailey [email protected]

@hug-dev hug-dev added the bug Something isn't working label Jun 19, 2020
@sbailey-arm sbailey-arm force-pushed the pkcs11-provider-fail-test-fix branch from 9ec290c to d426bd7 Compare June 19, 2020 11:28
@sbailey-arm sbailey-arm marked this pull request as ready for review June 19, 2020 11:52
hug-dev
hug-dev approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@hug-dev hug-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 👌 I don't know how if, in the future, it is possible to use Drop to implement those cleanup automatically, there are so many parameters to that call.

@ionut-arm
Copy link
Member

Nice find 👌 I don't know how if, in the future, it is possible to use Drop to implement those cleanup automatically, there are so many parameters to that call.

The parameters are one problem, another is the fact that in Drop you don't know whether the function succeeded or not.

ionut-arm
ionut-arm approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! As Hugues said, would be nice to at least come up with an idea of how to solve this without the cleanup code everywhere, in the long term!

@ionut-arm ionut-arm merged commit f82b042 into parallaxsecond:master Jun 19, 2020
@sbailey-arm sbailey-arm deleted the pkcs11-provider-fail-test-fix branch June 19, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionut-arm ionut-arm ionut-arm approved these changes

@hug-dev hug-dev hug-dev approved these changes

Assignees

@sbailey-arm sbailey-arm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbailey-arm @ionut-arm @hug-dev