Split provider code into separate modules #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit splits the code for the 3 existing providers into separate modules: one for key management (containing the code for key destruction, creation, import and export) and one for asymetric signing (currently containing code for signing and verifying hashes). Signed-off-by: Ionut Mihalcea <[email protected]>
hug-dev
approved these changes
Apr 30, 2020
Comment on lines
+74
to
+84
| // Build a valid ASN.1 DigestInfo DER-encoded structure by appending the hash to a | ||
| // DigestAlgorithmIdentifier value representing the SHA256 OID with no parameters. | ||
| // The OID used is: "2.16.840.1.101.3.4.2.1". | ||
| // It would be better to use the DigestInfo structure defined in this file but the | ||
| // AlgorithmIdentifier structure does not currently support the simple SHA256 OID. | ||
| // See Devolutions/picky-rs#19 | ||
| let mut digest_info = vec![ | ||
| 0x30, 0x31, 0x30, 0x0D, 0x06, 0x09, 0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, | ||
| 0x02, 0x01, 0x05, 0x00, 0x04, 0x20, | ||
| ]; | ||
| digest_info.append(&mut hash); |
There was a problem hiding this comment.
Not related at all with your PR but we should change that one of these days, since it has been fixed... by you 😋
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit splits the code for the 3 existing providers into separate
modules: one for key management (containing the code for key
destruction, creation, import and export) and one for asymetric signing
(currently containing code for signing and verifying hashes).
Signed-off-by: Ionut Mihalcea [email protected]
Fixes #133