Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key should be deleted from the KIM if generation/import fails #139

Closed
hug-dev opened this issue Apr 3, 2020 · 1 comment · Fixed by #144
Closed

Key should be deleted from the KIM if generation/import fails #139

hug-dev opened this issue Apr 3, 2020 · 1 comment · Fixed by #144
Assignees
@hug-dev
Labels
bug Something isn't working

Comments

@hug-dev
Copy link
Member

hug-dev commented Apr 3, 2020

If a key is generated or imported but execution fails during generation/import, the key should not be present in the Key ID Manager anymore.
An integration test should be created out of this.
@hug-dev hug-dev added the bug Something isn't working label Apr 3, 2020
hug-dev added a commit to hug-dev/parsec that referenced this issue Apr 16, 2020
@hug-dev
Add tests for operations edge cases
ea97115 
Adds many tests to make sure that the operations API is respected. Fixes
in the service the parts that are not compliant.
Also fixes parallaxsecond#139

Signed-off-by: Hugues de Valon <[email protected]>
@hug-dev hug-dev mentioned this issue Apr 16, 2020
Merged
hug-dev added a commit to hug-dev/parsec that referenced this issue Apr 16, 2020
@hug-dev
Add tests for operations edge cases
cddef85 
Adds many tests to make sure that the operations API is respected. Fixes
in the service the parts that are not compliant.
Also fixes parallaxsecond#139

Signed-off-by: Hugues de Valon <[email protected]>
hug-dev added a commit to hug-dev/parsec that referenced this issue Apr 16, 2020
@hug-dev
Add tests for operations edge cases
2968fde 
Adds many tests to make sure that the operations API is respected. Fixes
in the service the parts that are not compliant.
Also fixes parallaxsecond#139

Signed-off-by: Hugues de Valon <[email protected]>
hug-dev added a commit to hug-dev/parsec that referenced this issue Apr 17, 2020
@hug-dev
Add tests for operations edge cases
75627c0 
Adds many tests to make sure that the operations API is respected. Fixes
in the service the parts that are not compliant.
Also fixes parallaxsecond#139

Signed-off-by: Hugues de Valon <[email protected]>
hug-dev added a commit to hug-dev/parsec that referenced this issue Apr 17, 2020
@hug-dev
Add tests for operations edge cases
3fb11fb 
Adds many tests to make sure that the operations API is respected. Fixes
in the service the parts that are not compliant.
Also fixes parallaxsecond#139

Signed-off-by: Hugues de Valon <[email protected]>
@ionut-arm ionut-arm mentioned this issue Apr 20, 2020
Closed
@hug-dev hug-dev self-assigned this Apr 20, 2020
@hug-dev
Copy link
Member Author

hug-dev commented Apr 20, 2020

cc @egrimley-arm - this is fixed if you use latest master 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hug-dev hug-dev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for operations edge cases hug-dev/parsec
1 participant
@hug-dev