Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update html.js #2817

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Update html.js #2817

merged 1 commit into from
Jul 23, 2020

Conversation

kakugiki
Copy link
Contributor

Fix issue #2766 margin-top issue with zoom-in'ed page when using html2canvas.1.0.0-rc.5.js

@kakugiki
Update html.js
1d2cb9e 
Fix issue parallax#2766 margin-top issue with zoom-in'ed page
@HackbrettXXX
Copy link
Collaborator

Mmh, the CI test has finished but GitHub doesn't seem get that... Restarting by close/open...

@HackbrettXXX HackbrettXXX reopened this Jul 23, 2020
HackbrettXXX
HackbrettXXX reviewed Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another call to html2canvas in l.318. But I'm not sure if this code is actually reachable. The code in this file is so over-complex...

@kakugiki
Copy link
Contributor Author

Do you mean Worker.prototype.toCanvas? I can convert HTML to PDF without any issue even though the whole Worker.prototype.toCanvas code block is commented out. So yeah, I am not sure it's relevant.

@HackbrettXXX
Copy link
Collaborator

ok, I'm gonna merge it.

@HackbrettXXX HackbrettXXX merged commit 3c195a5 into parallax:master Jul 23, 2020
@kakugiki kakugiki deleted the patch2766 branch July 23, 2020 11:41
@kakugiki kakugiki mentioned this pull request Jul 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HackbrettXXX HackbrettXXX HackbrettXXX left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kakugiki @HackbrettXXX