Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bower installation error #3010

Closed
ghost opened this issue Nov 26, 2020 · 4 comments · Fixed by #3017
Closed

Bower installation error #3010

ghost opened this issue Nov 26, 2020 · 4 comments · Fixed by #3017
Labels
Bug

Comments

@ghost
Copy link

ghost commented Nov 26, 2020

When library is installed by Bower, it breaks the process with an error because there is a dependency that does not exist ("Package btoa not found").
@ghost
Copy link
Author

ghost commented Nov 27, 2020

I found a library (based on this one) that does work!

@HackbrettXXX
Copy link
Collaborator

Yeah, we can probably just remove atob and btoa from the dependencies in the bower.json file, since they are only required for node. Could you prepare a pull request?

@ghost
Copy link
Author

ghost commented Nov 27, 2020 •
edited by ghost
Loading

Sorry, I do not know deeply your library. It is only occurs to me to blank dependencies in Bower file.

HackbrettXXX added a commit to HackbrettXXX/jsPDF that referenced this issue Dec 3, 2020
@HackbrettXXX
remove atob and btoa dependencies from bower.json
68d61ee 
fix parallax#3010
@HackbrettXXX HackbrettXXX mentioned this issue Dec 3, 2020
Merged
HackbrettXXX added a commit that referenced this issue Dec 3, 2020
@HackbrettXXX
remove atob and btoa dependencies from bower.json (#3017)
314f058 
fix #3010
@ghost
Copy link
Author

ghost commented Dec 4, 2020

Nice! Thanks.

Now it is necessary upgrade version for Bower detects this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove atob and btoa dependencies from bower.json HackbrettXXX/jsPDF
1 participant
@HackbrettXXX