Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata: mark 44 as a supported version #788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matttbe
Copy link

@matttbe matttbe commented Mar 20, 2023

I'm using GNOME 44 beta (44~beta-1ubuntu1 on Ubuntu 23.04 with Wayland) and it looks like everything seems working fine after having forced version 44 support in metadata.js when using the development version of this add-on.

So I guess we can simply update this metadata.json file to allow this nice add-on to run on newer GNOME versions.

I'm using GNOME 44 beta (44~beta-1ubuntu1 on Ubuntu 23.04 with Wayland)
and it looks like everything seems working fine after having forced
version 44 support in metadata.js.

So I guess we can simply update the metadata.js to allow this nice
add-on to run on newer GNOME versions.
@mgalgs
Copy link
Collaborator

mgalgs commented Mar 21, 2023

Awesome. Anyone else have Gnome 44 test results?

@sidt4
Copy link

sidt4 commented Mar 24, 2023

Awesome. Anyone else have Gnome 44 test results?

Works fine after adding "44" to metadata.json in fedora rawhide GNOME Shell 44. Still facing #784 though its not a blocker.

$ cat /etc/fedora-release 
Fedora release 39 (Rawhide)

$ gnome-shell --version
GNOME Shell 44.0

@sidt4
Copy link

sidt4 commented Mar 24, 2023

So I guess we can simply update this metadata.js file to allow this nice add-on to run on newer GNOME versions.

You probably meant metadata.json.

@marxin
Copy link
Contributor

marxin commented Mar 27, 2023

Awesome. Anyone else have Gnome 44 test results?

Yes, works for me on the latest Tumbleweed with Gnome 44 release.

@NVieville
Copy link
Contributor

Hello,

As Fedora 38 is out since april 18 2023 with Gnome-Shell 44, I can confirm that this modification is necessary and it works well.

Cordially,

--
NVieville

@ZimbiX
Copy link
Collaborator

ZimbiX commented Apr 21, 2023

Resolves #791

@mgalgs
Copy link
Collaborator

mgalgs commented Apr 21, 2023

FYI for anyone looking for 44 support sooner than later, an equivalent patch has been merged into system-monitor-next. Pending review by the gnome team but should be live within the next day or two.

Edit: It's live! https://extensions.gnome.org/extension/3010/system-monitor-next/

@samueloph
Copy link

Any chance of merging this on master and tagging as a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants