Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the possibility to rearrange the graphs #700

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

DColadas
Copy link
Contributor

@DColadas DColadas commented Jul 6, 2021

Updates #612 to fix the conflicts. From that same PR:

I added some XML attributes and changed some code in enable() and the Settings window, making it possible to reorder the graphs (shown in the status bar and the information window) and the settings in the Settings window. This fixes #245 and is a nice feature.

To start rearranging, go to Settings, grab the tab label you wish to move, and drag it to its position. The changes in the order of the tabs are immediate (they will remain the next time the window is opened), but the displays in the status bar will only move after restarting GNOME Shell (Alt+F2 and the command r), although I may be able to work on improving it. The default order is the same as the previous one.

If you have some improvements (a better option than drag and dropping, for instance) or suggestions, feel free to comment!

Allowed drag-and-drop of the tabs in the Settings window.
The order of the displayed elements is the same as the order of the tabs.
Copy link
Collaborator

@ZimbiX ZimbiX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool! Well done =)

I think the tab dragging is a great way to do this, and I think is probably discoverable enough.

Without the order update taking immediate effect though, it could be good to add a note somewhere that a reload is required after changing it.

Tested rebased on #754.

Between tests, I used this to reset the position settings:

dconf dump /org/gnome/shell/extensions/system-monitor/ | grep position | cut -d= -f1 | xargs -I '{}' -- dconf reset '/org/gnome/shell/extensions/system-monitor/{}'

@@ -458,6 +458,46 @@
<default>false</default>
<summary>Hide system battery icon</summary>
</key>
<key name="cpu-position" type="i">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon change the indentation of these new settings to match the others. Might as well fix up the indentation of the other elements too while we're at it.

@chrisspen chrisspen merged commit d67658a into paradoxxxzero:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order of items changed
3 participants