feat: add decoding for individual trace steps #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Jul 1, 2024
| /// Represents a decoded internal function call. | ||
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| pub struct DecodedInternalCall { |
There was a problem hiding this comment.
maybe worth also adding an optional style field?
There was a problem hiding this comment.
we don't separate contract name and function name for internal calls, so I think func_name can be styled directly?
I think this could be useful, though not sure how to deal with serde for it
There was a problem hiding this comment.
Can be a follow-up where we add it to other structs as well
mattsse
approved these changes
Jul 1, 2024
DaniPopes
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref foundry-rs/foundry#8222
ref foundry-rs/foundry#8198
Adds structs and extends
TraceWriterto support formatting of decoded trace steps. Currently two decoding formats are supported:├─ [sload] <slot>to trace. It might make sense to extend it to something more configurable once we start implementing this