feat: add TreeConfig #9833
Merged
feat: add TreeConfig #9833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
requested review from
mattsse,
Rjected,
rkrasiuk and
gakonst
as code owners
mattsse
requested changes
Jul 26, 2024
There was a problem hiding this comment.
one suggestion
and we can re-export that type from etherem-engine like we did with other types already
reth/crates/ethereum/engine/src/service.rs
Lines 13 to 16 in cf7698a
Comment on lines
56
to
62
| /// Engine tree configuration builder. | ||
| #[derive(Debug, Default)] | ||
| pub struct TreeConfigBuilder { | ||
| persistence_threshold: Option<u64>, | ||
| block_buffer_limit: Option<u32>, | ||
| max_invalid_header_cache_length: Option<u32>, | ||
| } |
There was a problem hiding this comment.
I think the builder type is redundant here if we move the with setters to Treeconfig directly so you can configure it like TreeConfig::default().with_().with()
Comment on lines
-52
to
-58
| /// Maximum number of blocks to be kept only in memory without triggering persistence. | ||
| const PERSISTENCE_THRESHOLD: u64 = 256; | ||
| /// Number of pending blocks that cannot be executed due to missing parent and | ||
| /// are kept in cache. | ||
| const DEFAULT_BLOCK_BUFFER_LIMIT: u32 = 256; | ||
| /// Number of invalid headers to keep in cache. | ||
| const DEFAULT_MAX_INVALID_HEADER_CACHE_LENGTH: u32 = 256; |
There was a problem hiding this comment.
lets keep the constants but move to config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9821
The configuration is done at the launcher level (which adds a new dep to
reth-ethereum-node), we could do it at the service level too, let me know wdyt