Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clippy): make clippy happy #933

Merged
merged 1 commit into from
Jan 19, 2023
Merged

chore(clippy): make clippy happy #933

merged 1 commit into from
Jan 19, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 19, 2023

apply clippy suggestions

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jan 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #933 (8d5b720) into main (54e9b12) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
- Coverage   73.89%   73.88%   -0.02%     
==========================================
  Files         292      292              
  Lines       31763    31761       -2     
==========================================
- Hits        23472    23467       -5     
- Misses       8291     8294       +3     
Flag Coverage Δ
unit-tests 73.88% <85.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/stages/src/stages/hashing_storage.rs 96.11% <75.00%> (ø)
crates/stages/src/stages/hashing_account.rs 94.89% <100.00%> (-0.05%) ⬇️
crates/net/eth-wire/src/types/version.rs 77.77% <0.00%> (-2.23%) ⬇️
crates/net/network/src/manager.rs 49.79% <0.00%> (-0.21%) ⬇️
crates/net/network/src/peers/manager.rs 83.24% <0.00%> (-0.19%) ⬇️
crates/primitives/src/net.rs 94.68% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rkrasiuk rkrasiuk merged commit 013eb51 into main Jan 19, 2023
@rkrasiuk rkrasiuk deleted the matt/clippy-happy17 branch January 19, 2023 13:20
literallymarvellous pushed a commit to literallymarvellous/reth that referenced this pull request Feb 5, 2023
literallymarvellous pushed a commit to literallymarvellous/reth that referenced this pull request Feb 5, 2023
literallymarvellous pushed a commit to literallymarvellous/reth that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants