feat(discv5): config via cli #7394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
emhane
changed the title
mattsse
approved these changes
Apr 3, 2024
Comment on lines
+778
to
+780
| // work around since discv5 config builder can't be integrated into network config builder | ||
| // due to unsatisfied trait bounds | ||
| config.discovery_v5_with_config_builder(|builder| { |
There was a problem hiding this comment.
serialise and deserialise trait isn't implemented for discv5
Closed
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal exposure of discv5 config via CLI.
--instanceflag, for good devex in testing