Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): cache transaction hash when filtering over receipt logs #7074

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Mar 9, 2024

Makes sure to cache the transaction hash belonging to 1 receipt and N logs.

@joshieDo joshieDo added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Mar 9, 2024
@joshieDo joshieDo changed the title fix: cache transaction hash when filtering over receipt logs fix(rpc): cache transaction hash when filtering over receipt logs Mar 9, 2024
@joshieDo joshieDo marked this pull request as ready for review March 9, 2024 18:02
@gakonst
Copy link
Member

gakonst commented Mar 9, 2024

We gotta get this in for beta right @mattsse

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mattsse mattsse enabled auto-merge March 10, 2024 10:04
@mattsse mattsse added this pull request to the merge queue Mar 10, 2024
Merged via the queue into main with commit 84e9704 Mar 10, 2024
27 checks passed
@mattsse mattsse deleted the joshie/cache-txhash-logs branch March 10, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants