Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new mempool panels + existing mempool panels to new dashboard #7014

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Mar 6, 2024

  • Adds some new panels for the transaction pool into a new dashboard reth-mempool.
  • Copies existing transaction pool panels into new reth-mempool dashboard.
  • Makes it easier to review future changes to transaction pool panels that can now be reviewed in isolation.

As discussed with @shekhirin, updating the grafana dashboard is painful so long as it is not modular. Every new panel changes at least the grid position of existing panels placed lower than it.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested, but lgtm

@emhane emhane added this pull request to the merge queue Mar 6, 2024
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One small thing: we refer to the mempool as transaction pool throughout the codebase, can we do the same in the dashboard?

"title": "reth - mempool",

Also would appreciate a screenshot of this dashboard in the PR, as I didn't test it as well.

Merged via the queue into main with commit bd01fd8 Mar 6, 2024
27 checks passed
@emhane emhane deleted the emhane/mempool-panels branch March 6, 2024 18:25
@shekhirin
Copy link
Collaborator

screencapture-localhost-3000-d-bee34f59-c79c-4669-a000-198057b3703d-reth-mempool-2024-03-06-19_31_30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants