Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use proptest and keccak256 a lot, so make them way faster for a very small, insignificant cost to compile time, which is cached anyway in CI.
Some slow tests on my machine and CI
SealedBlockTests::proptest
: 20s to 2s, CI 60s, to 3.2stimestamped_forks
: 12.5s to 1.5s, CI 42.5s, to 4.7sfuzz_state_root_incremental
: 11.1s to 2.15s, CI 25s, to 4.2sprune_receipts_by_logs
: 3.5s to 0.5sThere are 2 tests that are hard coded to sleep 60s which is not ideal (#6994long_read_transaction_safety_disabled
), added in #6181 by @shekhirin. I don't know enough about that part of the code base to reduce their running time.stage_checkpoint_pruned
andexecute_intermediate_commit
are flaky, the first run it times out, then runs fine.Remaining slow tests are quite a few networking tests that also look hard coded to 5 / 10 seconds, like
txn_manager_read_transactions_duration_unbounded
,test_backoff_on_no_response
, cc @emhane @mattsse if there's anything we can do to make them faster, or if there's even a point in doing so.I've removed partitions for integration tests since the total running time is <30s with a 5m compile time, there is no point in splitting them.