Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): update engine api links #576

Merged
merged 1 commit into from
Dec 22, 2022
Merged

chore(docs): update engine api links #576

merged 1 commit into from
Dec 22, 2022

Conversation

rkrasiuk
Copy link
Member

Closes #571

@rkrasiuk rkrasiuk added C-docs An addition or correction to our documentation C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation and removed C-debt Refactor of code section that is hard to understand or maintain labels Dec 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #576 (a0d79d8) into main (c070e77) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   72.92%   72.92%           
=======================================
  Files         244      244           
  Lines       24690    24690           
=======================================
+ Hits        18004    18006    +2     
+ Misses       6686     6684    -2
Flag Coverage Δ
unit-tests 72.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/net/rpc-api/src/engine.rs 0.00% <ø> (ø)
crates/net/rpc-types/src/eth/engine.rs 12.50% <ø> (ø)
crates/stages/src/stages/bodies.rs 93.69% <0.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mattsse
mattsse approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 8f40c8b into main Dec 22, 2022
@mattsse mattsse deleted the rkrasiuk/docs-engine-links branch December 22, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update engine API spec links
3 participants
@rkrasiuk @codecov-commenter @mattsse