Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: chores #5280

Merged
merged 4 commits into from
Nov 4, 2023
Merged

ci: chores #5280

merged 4 commits into from
Nov 4, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 3, 2023

  • unpin nightly
  • update actions/checkout
  • use dtolnay/rust-toolchain everywhere
  • extract Geth installer to its own script
  • install cargo-udeps and cross using taiki-e/install-action
  • remove:
    • Fuzz workflow. Hasn't been run in over a year (ci: disable fuzzing jobs #559), and doesn't look like it ever will. Should probably also remove the macro automatically-generated fuzz tests. This should also be removed from PR requirements.
    • bench-success: should be removed from PR requirements since it doesn't do anything because benches run during merge groups.
    • sanity/dep-version-constraints: don't understand its purpose, it's just integration tests with a cargo update, but we update at the very least every week so this shouldn't be a problem. This also fails very often.
  • run success jobs on ubuntu-latest, not on reth runners

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending @onbjerg

@mattsse
Copy link
Collaborator

mattsse commented Nov 3, 2023

hmm, some success jobs are now waiting?

@DaniPopes
Copy link
Member Author

DaniPopes commented Nov 3, 2023

Need to remove some jobs from PR requirements. I don't have access to it

@onbjerg
Copy link
Member

onbjerg commented Nov 3, 2023

the reason the actions were named "lint success" etc instead of just success is that github's ui will not differentiate them when adding required actions in the dropdown, making it near impossible to add them. plz keep the old names for that reason

@DaniPopes
Copy link
Member Author

Figured, though I thought it would be the ID not the name. Updated

@DaniPopes DaniPopes enabled auto-merge November 4, 2023 23:10
@DaniPopes DaniPopes added this pull request to the merge queue Nov 4, 2023
Merged via the queue into main with commit 6e0cf0f Nov 4, 2023
19 checks passed
@DaniPopes DaniPopes deleted the ci-chores branch November 4, 2023 23:33
mattsse pushed a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants