-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kzg_to_versioned_hash #4085
feat: add kzg_to_versioned_hash #4085
Conversation
Codecov Report
... and 17 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainly nits and comments on style
needs to be updated now that #4084 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small nit, otherwise this looks good to me
d0de8c5
to
4de1ff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, just some small things that were probably due to rebase. after making changes make sure to run cargo +nightly fmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, LGTM!
Co-authored-by: Dan Cline <[email protected]>
This adds
kzg_to_versioned_hash
as a helper method to reth_primitivesblobfee
module toeip4844
.