Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: cover index storage history stage with stage_test_suite_ext tests #3898

Merged
merged 1 commit into from
Jul 26, 2023
Merged

test: cover index storage history stage with stage_test_suite_ext tests #3898

merged 1 commit into from
Jul 26, 2023

Conversation

int88
Copy link
Contributor

@int88 int88 commented Jul 25, 2023

fixes part of #3232

@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #3898 (dbe1404) into main (993b844) will increase coverage by 0.02%.
The diff coverage is 90.47%.

Impacted file tree graph

Files Changed Coverage Δ
crates/stages/src/stages/index_storage_history.rs 96.12% <90.47%> (-1.93%) ⬇️

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.52% <0.00%> (-0.03%) ⬇️
unit-tests 64.45% <90.47%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.44% <ø> (ø)
blockchain tree 83.01% <ø> (ø)
pipeline 89.70% <90.47%> (+0.03%) ⬆️
storage (db) 74.19% <ø> (ø)
trie 94.65% <ø> (ø)
txpool 46.00% <ø> (ø)
networking 77.68% <ø> (ø)
rpc 58.25% <ø> (-0.04%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.99% <ø> (-0.02%) ⬇️

@int88
Copy link
Contributor Author

int88 commented Jul 25, 2023

@shekhirin PTAL

shekhirin
shekhirin approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very similar to #3383. @rakita ptal 👀

@onbjerg onbjerg added the C-test A change that impacts how or what we test label Jul 26, 2023
@shekhirin
Copy link
Collaborator

As I said, it's quite similar to account history index tests, so we should be good to go.

@shekhirin shekhirin added this pull request to the merge queue Jul 26, 2023
Merged via the queue into paradigmxyz:main with commit adce7ea Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@int88 @shekhirin @onbjerg