Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): in-memory merkle debug script #3895

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Jul 24, 2023

Description

The debug routine for inspecting the in-memory merkle root calculation.

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-cli Related to the reth CLI A-trie Related to Merkle Patricia Trie implementation labels Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #3895 (341ad2b) into main (019ead3) will decrease coverage by 0.16%.
The diff coverage is 1.09%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/debug_cmd/execution.rs 1.16% <ø> (ø)
bin/reth/src/debug_cmd/mod.rs 0.00% <0.00%> (ø)
bin/reth/src/utils.rs 3.33% <0.00%> (-1.36%) ⬇️
crates/trie/src/updates.rs 89.87% <0.00%> (ø)
bin/reth/src/debug_cmd/in_memory_merkle.rs 1.29% <1.29%> (ø)

... and 14 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.50% <0.00%> (-0.06%) ⬇️
unit-tests 64.27% <1.09%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.50% <1.09%> (-0.94%) ⬇️
blockchain tree 83.01% <ø> (ø)
pipeline 89.66% <ø> (ø)
storage (db) 74.19% <ø> (ø)
trie 94.65% <0.00%> (ø)
txpool 46.56% <ø> (+0.56%) ⬆️
networking 77.65% <ø> (-0.08%) ⬇️
rpc 58.28% <ø> (ø)
consensus 64.33% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.98% <ø> (-0.04%) ⬇️

@rkrasiuk rkrasiuk marked this pull request as ready for review July 27, 2023 07:44
@rkrasiuk rkrasiuk requested review from onbjerg and gakonst as code owners July 27, 2023 07:44
@rkrasiuk rkrasiuk requested a review from Rjected July 27, 2023 18:05
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + tested:

  • on non-corrupted DB, the test passes
  • on corrupted DB, the failure is reliable

@rkrasiuk rkrasiuk added this pull request to the merge queue Jul 28, 2023
Merged via the queue into main with commit 703d5c7 Jul 28, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/debug-in-memory-merkle branch July 28, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants