Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): ots_hasCode implementation #3886

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

ZePedroResende
Copy link
Contributor

These changes tackle #3726

  • Add implementation of ots_hasCode to ots namespace
  • Add http tests for ots_hasCode

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nit

crates/rpc/rpc/src/otterscan.rs Outdated Show resolved Hide resolved
Co-authored-by: Matthias Seitz <[email protected]>
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #3886 (cf63794) into main (39cd0e0) will decrease coverage by 56.23%.
The diff coverage is 4.54%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/consensus/auto-seal/src/lib.rs 0.00% <0.00%> (ø)
crates/payload/basic/src/lib.rs 0.00% <0.00%> (ø)
crates/primitives/src/constants.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/primitives/src/transaction/mod.rs 15.69% <0.00%> (-67.49%) ⬇️
crates/rpc/rpc-types/src/eth/filter.rs 0.00% <0.00%> (-68.99%) ⬇️
crates/rpc/rpc/src/eth/api/pending_block.rs 0.00% <0.00%> (ø)
crates/transaction-pool/src/lib.rs 17.68% <0.00%> (-14.64%) ⬇️
crates/transaction-pool/src/maintain.rs 0.00% <0.00%> (-3.34%) ⬇️
crates/transaction-pool/src/noop.rs 11.02% <0.00%> (ø)
crates/transaction-pool/src/pool/best.rs 0.00% <0.00%> (-75.00%) ⬇️
... and 8 more

... and 373 files with indirect coverage changes

Flag Coverage Δ
integration-tests 12.49% <4.54%> (-3.07%) ⬇️
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 6.20% <ø> (-20.28%) ⬇️
blockchain tree 0.00% <ø> (-83.03%) ⬇️
pipeline 0.00% <ø> (-89.61%) ⬇️
storage (db) 16.45% <ø> (-57.81%) ⬇️
trie 0.00% <ø> (-94.66%) ⬇️
txpool 15.32% <5.88%> (-31.26%) ⬇️
networking 17.77% <ø> (-59.94%) ⬇️
rpc 20.96% <4.16%> (-36.55%) ⬇️
consensus 1.04% <0.00%> (-64.25%) ⬇️
revm 1.44% <ø> (-32.24%) ⬇️
payload builder 6.61% <0.00%> (ø)
primitives 13.67% <0.00%> (-74.41%) ⬇️

@mattsse mattsse added this pull request to the merge queue Jul 24, 2023
@onbjerg onbjerg added C-enhancement New feature or request M-changelog This change should be included in the changelog A-rpc Related to the RPC implementation labels Jul 24, 2023
Merged via the queue into paradigmxyz:main with commit 3ff9be6 Jul 24, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
Co-authored-by: Miguel Palhas <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants