Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add key gen util and simple fcu validation test with custom alloc #3842

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jul 18, 2023

Adds two utility methods: generate_keys which just generates a set of key pairs, and public_key_to_address, which converts a PublicKey to Address, hiding details about serialization, hashing, and slicing in the implementation.

Adds another FCU test that validates empty blocks on top of a genesis with a custom alloc.

ref #3836

@Rjected Rjected added C-enhancement New feature or request A-consensus Related to the consensus engine C-test A change that impacts how or what we test labels Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #3842 (d3060c6) into main (5ad9b32) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/primitives/src/lib.rs 100.00% <ø> (ø)
crates/consensus/beacon/src/engine/mod.rs 77.02% <100.00%> (+1.67%) ⬆️
crates/interfaces/src/test_utils/generators.rs 90.85% <100.00%> (+0.05%) ⬆️
crates/primitives/src/transaction/util.rs 100.00% <100.00%> (ø)

... and 30 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.55% <12.06%> (-0.02%) ⬇️
unit-tests 64.22% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.48% <ø> (ø)
blockchain tree 83.02% <ø> (ø)
pipeline 89.60% <ø> (+2.55%) ⬆️
storage (db) 74.26% <ø> (+0.07%) ⬆️
trie 94.65% <ø> (ø)
txpool 46.55% <ø> (+0.56%) ⬆️
networking 77.66% <ø> (+0.11%) ⬆️
rpc 57.93% <ø> (-0.02%) ⬇️
consensus 65.61% <100.00%> (+0.94%) ⬆️
revm 33.73% <ø> (+0.02%) ⬆️
payload builder 6.61% <ø> (ø)
primitives 88.05% <100.00%> (+<0.01%) ⬆️

@Rjected Rjected force-pushed the dan/add-more-generators branch from 0e5eabd to 7e65610 Compare July 18, 2023 19:02
@mattsse mattsse added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit 314e561 Jul 18, 2023
@mattsse mattsse deleted the dan/add-more-generators branch July 18, 2023 21:41
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine C-enhancement New feature or request C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants