Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let consensus tests configure pipeline, executor, and client #3839

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jul 18, 2023

Allows the consensus tests to configure a real pipeline (with DefaultStages), a real executor, and a real download client. This lets us locally integration test consensus actions, insert blocks that the consensus engine will fetch (for example with the TestFullBlockClient) and perform real block validation in tests.

Fixes #3835

@Rjected Rjected added C-enhancement New feature or request A-consensus Related to the consensus engine C-test A change that impacts how or what we test labels Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #3839 (9129198) into main (26b1ffa) will decrease coverage by 0.14%.
The diff coverage is 83.69%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/consensus/beacon/src/engine/mod.rs 75.34% <83.69%> (-1.44%) ⬇️

... and 14 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.59% <0.00%> (-0.06%) ⬇️
unit-tests 64.07% <83.69%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.49% <ø> (ø)
blockchain tree 83.02% <ø> (ø)
pipeline 87.04% <ø> (ø)
storage (db) 74.32% <ø> (ø)
trie 94.65% <ø> (ø)
txpool 46.82% <ø> (-0.04%) ⬇️
networking 77.55% <ø> (-0.04%) ⬇️
rpc 58.33% <ø> (-0.61%) ⬇️
consensus 64.66% <83.69%> (-0.39%) ⬇️
revm 33.80% <ø> (+0.04%) ⬆️
payload builder 6.61% <ø> (ø)
primitives 88.05% <ø> (-0.02%) ⬇️

@Rjected Rjected added this pull request to the merge queue Jul 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2023
@Rjected Rjected added this pull request to the merge queue Jul 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2023
@mattsse mattsse added this pull request to the merge queue Jul 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2023
@mattsse mattsse added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit 5ad9b32 Jul 18, 2023
@mattsse mattsse deleted the dan/add-rich-testing-utils branch July 18, 2023 18:53
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine C-enhancement New feature or request C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend consensus test builders with real components
2 participants