Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build profile to version info take II #3669

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

michaelsproul
Copy link
Contributor

re-do of #3652, now with proper cross-compilation

the reason that the previous version failed in CI here is that it was trying to split on the Windows path separator on Linux (the host)

I've confirmed that this updated version compiles successfully with make build-x86_64-pc-windows-gnu as well as ordinary make install on Linux.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for submitting this again

needs nightly fmt

@mattsse mattsse added the A-cli Related to the reth CLI label Jul 8, 2023
@mattsse mattsse enabled auto-merge July 8, 2023 10:39
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #3669 (377cc84) into main (42a824c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

Impacted Files Coverage Δ
bin/reth/src/version.rs 47.36% <0.00%> (-42.64%) ⬇️

... and 5 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.91% <0.00%> (+<0.01%) ⬆️
unit-tests 64.09% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.35% <0.00%> (-0.06%) ⬇️
blockchain tree 81.25% <ø> (ø)
pipeline 86.69% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 94.66% <ø> (ø)
txpool 49.34% <ø> (ø)
networking 77.86% <ø> (ø)
rpc 58.12% <ø> (-0.03%) ⬇️
consensus 63.35% <ø> (ø)
revm 34.86% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.27% <ø> (+0.03%) ⬆️

@mattsse mattsse added this pull request to the merge queue Jul 8, 2023
Merged via the queue into paradigmxyz:main with commit 1330fc1 Jul 8, 2023
@michaelsproul michaelsproul deleted the build-profile-II branch July 8, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants