Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pending receipts #3320

Merged
merged 1 commit into from
Jun 22, 2023
Merged

feat: add pending receipts #3320

merged 1 commit into from
Jun 22, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 22, 2023

adds additional functions to get receipts of pending block.

This removes the blanket ReceiptProviderIdExt and implements custom logic for BlockchainProvider to handle pending block

@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Jun 22, 2023
@mattsse mattsse force-pushed the matt/add-pending-receipts branch from 85139a9 to 306f749 Compare June 22, 2023 11:59
@mattsse mattsse force-pushed the matt/add-pending-receipts branch from 306f749 to 2222ea1 Compare June 22, 2023 12:03
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #3320 (2222ea1) into main (1d3bab6) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3320      +/-   ##
==========================================
- Coverage   69.76%   69.68%   -0.08%     
==========================================
  Files         531      531              
  Lines       71669    71707      +38     
==========================================
- Hits        49997    49968      -29     
- Misses      21672    21739      +67     
Flag Coverage Δ
integration-tests 16.34% <0.00%> (-0.02%) ⬇️
unit-tests 64.73% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/blockchain-tree/src/blockchain_tree.rs 82.09% <0.00%> (-0.55%) ⬇️
crates/blockchain-tree/src/shareable.rs 42.72% <0.00%> (-1.62%) ⬇️
crates/interfaces/src/blockchain_tree/mod.rs 31.57% <0.00%> (-1.76%) ⬇️
crates/rpc/rpc/src/debug.rs 11.08% <ø> (ø)
crates/storage/provider/src/chain.rs 75.80% <0.00%> (-1.25%) ⬇️
crates/storage/provider/src/providers/mod.rs 8.68% <0.00%> (-0.37%) ⬇️
crates/storage/provider/src/test_utils/mock.rs 25.85% <ø> (ø)
crates/storage/provider/src/test_utils/noop.rs 26.43% <ø> (ø)
crates/storage/provider/src/traits/block.rs 30.76% <ø> (ø)
crates/storage/provider/src/traits/receipts.rs 43.75% <0.00%> (-26.25%) ⬇️

... and 6 files with indirect coverage changes

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah this makes sense, nice!

@mattsse mattsse added this pull request to the merge queue Jun 22, 2023
Merged via the queue into main with commit e8b09cc Jun 22, 2023
@mattsse mattsse deleted the matt/add-pending-receipts branch June 22, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants