Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: indent stuff in #1833 #1835

Merged
merged 2 commits into from
Mar 18, 2023
Merged

chore: indent stuff in #1833 #1835

merged 2 commits into from
Mar 18, 2023

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Mar 18, 2023

Some things rustfmt missed

@onbjerg onbjerg added the C-debt Refactor of code section that is hard to understand or maintain label Mar 18, 2023
@onbjerg onbjerg requested a review from gakonst as a code owner March 18, 2023 13:22
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that even nightly fmt misses this.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Merging #1835 (64d5b81) into main (075544e) will decrease coverage by 12.69%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main    #1835       +/-   ##
===========================================
- Coverage   73.50%   60.82%   -12.69%     
===========================================
  Files         410      410               
  Lines       50486    50486               
===========================================
- Hits        37110    30708     -6402     
- Misses      13376    19778     +6402     
Flag Coverage Δ
integration-tests 19.72% <0.00%> (+0.01%) ⬆️
unit-tests 53.69% <0.00%> (-14.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc-engine-api/src/engine_api.rs 68.44% <0.00%> (-23.85%) ⬇️

... and 142 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@onbjerg onbjerg merged commit 100d4a9 into main Mar 18, 2023
@onbjerg onbjerg deleted the onbjerg/indent branch March 18, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants