feat: use chain specific bootnodes #1826
Conversation
Rjected
force-pushed
the
dan/use-chain-bootnodes
branch
from
ef7567d to
5652cb1
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1826 +/- ##
==========================================
+ Coverage 72.50% 73.51% +1.00%
==========================================
Files 411 410 -1
Lines 50502 50510 +8
==========================================
+ Hits 36617 37130 +513
+ Misses 13885 13380 -505
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 38 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bin/reth/src/args/network_args.rs
Outdated
| let chain_bootnodes = match chain_spec.chain.try_into() { | ||
| Ok(Chain::Mainnet) => mainnet_nodes(), | ||
| Ok(Chain::Goerli) => goerli_nodes(), | ||
| Ok(Chain::Sepolia) => sepolia_nodes(), | ||
| _ => mainnet_nodes(), | ||
| }; | ||
|
|
There was a problem hiding this comment.
I'd like to make this a Chain function, similar to
reth/crates/primitives/src/chain/mod.rs
Line 64 in 5652cb1
There was a problem hiding this comment.
Since the constants are in reth_discv4, I guess those should move to primitives as well
Previously, unless explicitly specified, we would always use the mainnet bootnodes. This will use the bootnodes specific to the specified chain when running
reth node.