feat: add storage_proof_only argument to RollupArgs
#13009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
A-rpc
joshieDo
changed the title
storage_proofs_only to RollupArgsstorage_proof_only argument to RollupArgs
mattsse
requested changes
Nov 29, 2024
crates/optimism/rpc/src/eth/mod.rs
Outdated
Comment on lines
93
to
97
| pub fn new( | ||
| ctx: &EthApiBuilderCtx<N>, | ||
| sequencer_http: Option<String>, | ||
| storage_proof_only: Vec<Address>, | ||
| ) -> Self { |
There was a problem hiding this comment.
I have a feeling we might need more settings in the future so we should change the way we configure this with some builder types for OpEthApi and OpAddons
like
let api = OpEthApi::builder(ctx).with_sequencer().proof_only().build()same for OpAddons
crates/optimism/rpc/src/eth/mod.rs
Outdated
| @@ -67,6 +74,9 @@ pub struct OpEthApi<N: RpcNodeCore> { | |||
| /// Sequencer client, configured to forward submitted transactions to sequencer of given OP | |||
| /// network. | |||
| sequencer_client: Option<SequencerClient>, | |||
| /// List of addresses that _ONLY_ return storage proofs _WITHOUT_ an account proof when called | |||
| /// with `eth_getProof`. | |||
| storage_proof_only: Vec<Address>, | |||
There was a problem hiding this comment.
we should wrap all of those fields in a new Arced OpEthApiInner type because this is cloned per request
joshieDo
requested review from
Rjected,
fgimenez,
emhane and
gakonst
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically moved from odyssey, but without the need to replace the
http/authmodulesAlso, adds
OpAddonsBuilderandOpEthApiBuilder