Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Primitives AT to BlockExecutorProvider #12994

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Nov 28, 2024

Based on #12991

Changes in this PR:

  • Primitives AT is added to BlockExecutionStrategy, BlockExecutionStrategyFactory and BlockExecutorProvider which affects type of blocks in inputs and type of receipts in outputs.
  • reth-exex types that operate on ExExNotification are now generic over NodePrimitives — types which hold a BlockExecutorProvider access it as E::Primitives, all other types have a new generic now. Bounds for ExEx types are updated, mostly with diff similar to
    -    P: BlockReader<Block = reth_primitives::Block>
    -    E: BlockExecutorProvider
    +    P: BlockReader,
    +    E: BlockExecutorProvider<Primitives: NodePrimitives<Block = P::Block>>,
    i.e block bounds are simplified to just bound block fetched from db to the block type expected by executor which should be flexible enough for any primitive types
  • ExecutionStage bounds are similarly relaxed, making it independent of block type

@klkvr klkvr changed the title feat: add Primitives AT to BlockExecutionProvider feat: add Primitives AT to BlockExecutorProvider Nov 28, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@mattsse mattsse added the A-sdk Related to reth's use as a library label Nov 29, 2024
Base automatically changed from klkvr/serde-bincode-compat to main November 29, 2024 12:38
@klkvr klkvr enabled auto-merge November 29, 2024 12:41
@klkvr klkvr added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 29289cc Nov 29, 2024
42 checks passed
@klkvr klkvr deleted the klkvr/generic-execution branch November 29, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants