feat: relax provider bounds #12857
Merged
feat: relax provider bounds #12857
+365
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/provider-abstraction
branch
from
5c0b4a4
to
e57cc67
Compare
klkvr
force-pushed
the
klkvr/provider-abstraction
branch
from
0c09103
to
0a84d44
Compare
onbjerg
approved these changes
Nov 26, 2024
| @@ -30,9 +31,18 @@ pub trait BlockBody: | |||
| /// Ordered list of signed transactions as committed in block. | |||
| type Transaction: Transaction; | |||
|
|
|||
| /// Ommer header type. | |||
| type Header; | |||
There was a problem hiding this comment.
lets rename this to Ommer or similar in that case? for clarity
onbjerg
added
the
C-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #12855
This PR relaxes bounds for database providers and
BlockchainProvider2wrapping up their abstraction over body and transaction. LegacyBlockchainProvideris still bounded by concreteEthPrimitivesthroughTreeNodeTypestrait.We still need
Block = reth_primitives::Blockbounds for execution, engine and rpc types, so those bounds. are moved above from providers to those components.To fit into current providers and rpc structure, I've extended
BlockBodywith Ethereum-specific withdrawals and ommers methods. It might make sense to decouple them at some point to clean up the abstraction