chore: simplify cost calc #12796
Merged
chore: simplify cost calc #12796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/simplify-cost-calc
branch
from
6672e35
to
e17df6c
Compare
mattsse
added
C-debt
klkvr
reviewed
Nov 22, 2024
| U256::from(t.max_fee_per_gas).saturating_mul(U256::from(t.gas_limit)) | ||
| } | ||
| Transaction::Eip4844(t) => { | ||
| blob_sidecar = EthBlobTransactionSidecar::Missing; |
There was a problem hiding this comment.
this is now never set to Missing, should we still do it?
klkvr
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use existing tx functions