Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EthereumEthApiTypes #12618

Merged
merged 1 commit into from
Nov 18, 2024
Merged

feat: add EthereumEthApiTypes #12618

merged 1 commit into from
Nov 18, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 18, 2024

adds a standalone EthApiType implementation for ethereum.

this makes it easier to create things like:

pub struct EthFilter<Provider, Pool, Eth: EthApiTypes> {
/// All nested fields bundled together
inner: Arc<EthFilterInner<Provider, Pool, RpcTransaction<Eth::NetworkTypes>>>,
/// Assembles response data w.r.t. network.
tx_resp_builder: Eth::TransactionCompat,
}

that need the compat

@mattsse mattsse added the C-enhancement New feature or request label Nov 18, 2024
@mattsse mattsse added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 4daec16 Nov 18, 2024
41 checks passed
@mattsse mattsse deleted the matt/add-ethereum-eth-api-types branch November 18, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants