Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: use BlockWithParent in SyncTarget::Gap #12514

Merged
merged 5 commits into from
Nov 15, 2024
Merged

net: use BlockWithParent in SyncTarget::Gap #12514

merged 5 commits into from
Nov 15, 2024

Conversation

tcoratger
Copy link
Contributor

Should close #12493

mattsse
mattsse approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Nov 15, 2024
Merged via the queue into paradigmxyz:main with commit 93ec6d4 Nov 15, 2024
40 checks passed
@tcoratger tcoratger mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce helper type for two BlockHashes
2 participants
@tcoratger @mattsse