Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move trie functions to alloy #12438

Merged
merged 3 commits into from
Nov 12, 2024
Merged

chore: move trie functions to alloy #12438

merged 3 commits into from
Nov 12, 2024

Conversation

c0np4nn4
Copy link
Contributor

@c0np4nn4 c0np4nn4 commented Nov 10, 2024 •
edited
Loading

close #11211

mattsse
mattsse requested changes Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please undo the additional ;, otherwise lgtm

@Rjected Rjected added C-enhancement New feature or request A-sdk Related to reth's use as a library labels Nov 12, 2024
Rjected
Rjected previously requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs cargo fmt + must propagate the std feature now, otherwise looks good

@mattsse mattsse added this pull request to the merge queue Nov 12, 2024
Merged via the queue into paradigmxyz:main with commit c261532 Nov 12, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@fgimenez fgimenez fgimenez approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move trie functions to alloy
4 participants
@c0np4nn4 @fgimenez @Rjected @mattsse