Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove trait bound on TxType #12379

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

ftupas
Copy link
Contributor

@ftupas ftupas commented Nov 7, 2024

This pr does the following:

  • removes trait bound From<alloy_consensus::TxType>
    /// Trait representing the behavior of a transaction type.
    pub trait TxType:
    Into<u8>
    + Into<U8>
    + PartialEq
    + Eq
    + PartialEq<u8>
    + TryFrom<u8, Error = Eip2718Error>
    + TryFrom<u64>
    + TryFrom<U64>
    + From<alloy_consensus::TxType>
    + Debug
    + Display
    + Clone
    + Copy
    + Default
    + Encodable
    + Decodable
    + Send
    + Sync
    + 'static
    {
    }
  • refactor tests and use rstest
  • resolves Remove trait bound on TxType #12346

Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would have been preferred if the tests refactor came in a separate pr, makes more sense to review like that

@emhane emhane added this pull request to the merge queue Nov 10, 2024
Merged via the queue into paradigmxyz:main with commit c1b4fd8 Nov 10, 2024
41 checks passed
@ftupas ftupas deleted the refactor/remove-trait-bound-on-TxType branch November 10, 2024 22:30
@ftupas
Copy link
Contributor Author

ftupas commented Nov 10, 2024

would have been preferred if the tests refactor came in a separate pr, makes more sense to review like that

gotcha I could create an issue to do a proper refactor of the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove trait bound on TxType
2 participants