feat(payload) : optimize new payload job by fetching only header hash instead of block #12343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lean-apple
commented
Nov 6, 2024
Comment on lines
+147
to
159
| let parent_header = if attributes.parent().is_zero() { | ||
| // Use latest header for genesis block case | ||
| self.client | ||
| .block_by_number_or_tag(BlockNumberOrTag::Latest)? | ||
| .ok_or_else(|| PayloadBuilderError::MissingParentBlock(attributes.parent()))? | ||
| .seal_slow() | ||
| .latest_header() | ||
| .map_err(PayloadBuilderError::from)? | ||
| .ok_or_else(|| PayloadBuilderError::MissingParentHeader(B256::ZERO))? | ||
| } else { | ||
| let block = self | ||
| .client | ||
| .find_block_by_hash(attributes.parent(), BlockSource::Any)? | ||
| .ok_or_else(|| PayloadBuilderError::MissingParentBlock(attributes.parent()))?; | ||
|
|
||
| // we already know the hash, so we can seal it | ||
| block.seal(attributes.parent()) | ||
| // Fetch specific header by hash | ||
| self.client | ||
| .sealed_header_by_hash(attributes.parent()) | ||
| .map_err(PayloadBuilderError::from)? | ||
| .ok_or_else(|| PayloadBuilderError::MissingParentHeader(attributes.parent()))? | ||
| }; |
mattsse
added
C-perf
hai-rise
reviewed
Nov 6, 2024
| // Fetch specific header by hash | ||
| self.client | ||
| .sealed_header_by_hash(attributes.parent()) | ||
| .map_err(PayloadBuilderError::from)? |
There was a problem hiding this comment.
We don't seem to need these map_errs?
hai-rise
reviewed
Nov 6, 2024
| let config = | ||
| PayloadConfig::new(Arc::new(header), self.config.extradata.clone(), attributes); | ||
| let config = PayloadConfig::new( | ||
| Arc::new(parent_header.clone()), |
There was a problem hiding this comment.
Nit but we won't need this clone if we use an intermediate hash like previously, or simply create cached_reads before config 🙏.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization in response of this comment.