feat(engine): integrate executor with StateRootTask #12335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
added
C-perf
fgimenez
force-pushed
the
fgimenez/integrate-executor-srt
branch
from
f77f761
to
1bf8ed8
Compare
fgimenez
force-pushed
the
fgimenez/metered-executor-with-state-hook
branch
from
ae5150e
to
f935262
Compare
fgimenez
force-pushed
the
fgimenez/integrate-executor-srt
branch
from
1bf8ed8
to
d7a2b48
Compare
fgimenez
force-pushed
the
fgimenez/integrate-executor-srt
branch
from
6586622
to
77b913a
Compare
rkrasiuk
reviewed
Nov 6, 2024
Base automatically changed from
fgimenez/metered-executor-with-state-hook
to
main
November 6, 2024 11:54
fgimenez
force-pushed
the
fgimenez/integrate-executor-srt
branch
from
77b913a
to
ba4a804
Compare
rkrasiuk
reviewed
Nov 6, 2024
Co-authored-by: Roman Krasiuk <[email protected]>
fgimenez
force-pushed
the
fgimenez/integrate-executor-srt
branch
from
300aca1
to
53582dd
Compare
rkrasiuk
approved these changes
Nov 6, 2024
Comment on lines
+110
to
+111
| // stream closed, return final result | ||
| return Poll::Ready(Ok((B256::default(), TrieUpdates::default()))); |
There was a problem hiding this comment.
stream getting closed does not mean we finished the computation, let's leave it as unimplemented
Suggested change
| // stream closed, return final result | |
| return Poll::Ready(Ok((B256::default(), TrieUpdates::default()))); | |
| unimplemented!() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: #12053
Requires: #12316
Creates a
StateRootTaskinstance and wires it with the state hook passed to the executor using an unbounded channel. For now theStateRootTaskinstance is not created yet, some TODOs added for when all the functionality is in place and we can switch to use it.