-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): optimize block validation with state caching #12299
feat(rpc): optimize block validation with state caching #12299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the late review.
this looks great, only have two nits really
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
I only extracted the cached_read ops into standalone functions
Pull request was closed
Sorry @mattsse though it was already merged 🙈 |
Closes #12266.
Introduces state caching with
CachedReads
for block validation.Some next optimizations could be after checking the behavior :