chore(reth_primitives): Use trait for size methods in primitive types
#12201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TropicalDog17
requested review from
mattsse,
Rjected,
emhane,
shekhirin,
joshieDo,
onbjerg,
rkrasiuk and
gakonst
as code owners
Rjected
previously requested changes
Oct 30, 2024
crates/primitives-traits/src/size.rs
Outdated
| @@ -0,0 +1,5 @@ | |||
| /// Trait for calculating a heuristic for the in-memory size of a struct. | |||
| pub trait HeuristicSize { | |||
There was a problem hiding this comment.
maybe name it SizeHeuristic, or InMemorySize or something like that
| @@ -4,13 +4,14 @@ use crate::{ | |||
| PrunerError, | |||
| }; | |||
| use reth_db::{tables, transaction::DbTxMut}; | |||
| #[allow(unused_imports)] | |||
Comment on lines
163
to
173
|
|
||
| /// Convert [`reth_primitives::TxType`] to [`alloy_consensus::TxType`] | ||
| /// Will panics if the `TxType` is `TxType::Deposit` (Optimism Deposit transaction) | ||
| pub fn tx_type_to_alloy(tx_type: TxType) -> alloy_consensus::TxType { | ||
| u8::from(tx_type).try_into().unwrap() | ||
| } | ||
|
|
||
| /// Convert [`alloy_consensus::TxType`] to [`reth_primitives::TxType`] | ||
| pub fn tx_type_from_alloy(tx_type: alloy_consensus::TxType) -> TxType { | ||
| u8::from(tx_type).try_into().unwrap() | ||
| } |
There was a problem hiding this comment.
these changes are unrelated right?
There was a problem hiding this comment.
yeah sorry I messed up my local branch
crates/transaction-pool/src/lib.rs
Outdated
| @@ -157,6 +157,7 @@ use aquamarine as _; | |||
| use reth_eth_wire_types::HandleMempoolData; | |||
| use reth_execution_types::ChangedAccount; | |||
| use reth_primitives::{BlobTransactionSidecar, PooledTransactionsElement}; | |||
| use reth_primitives_traits as _; | |||
Comment on lines
28
to
29
| #[cfg(any(test, feature = "arbitrary"))] | ||
| use reth_primitives_traits::HeuristicSize; |
There was a problem hiding this comment.
if the use reth_primitives_traits as _; is required since this is feature gated, I'd try to instead make primitives-traits an optional dep, including it by default as a dev-dependency, and when arbitrary is enabled
mattsse
force-pushed
the
chore/size-trait
branch
from
2777384
to
ba032e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3893