Deduplicate primitive types and use alloy's existing types

[mattsse]

Describe the feature

ref alloy-rs/alloy#255

ref #5746

currently all codec traits are implemented in reth-primitives via derive macros, therefor we're duplicating types that already exists in alloy:

reth/crates/primitives/src/transaction/access_list.rs

Lines 43 to 46 in 9569692

	/// AccessList as defined in [EIP-2930](https://eips.ethereum.org/EIPS/eip-2930)
	#[main_codec(rlp)]
	#[derive(Clone, Debug, PartialEq, Eq, Hash, Default, RlpDecodableWrapper, RlpEncodableWrapper)]
	pub struct AccessList(

reth/crates/primitives/src/withdrawal.rs

Lines 9 to 12 in 9569692

	/// Withdrawal represents a validator withdrawal from the consensus layer.
	#[main_codec]
	#[derive(Debug, Clone, PartialEq, Eq, Default, Hash, RlpEncodable, RlpDecodable)]
	pub struct Withdrawal {

reth/crates/primitives/src/log.rs

Lines 6 to 9 in 9569692

	/// Ethereum Log
	#[main_codec(rlp)]
	#[derive(Clone, Debug, PartialEq, Eq, RlpDecodable, RlpEncodable, Default)]
	pub struct Log {

In order to replace them, we need to impl all the codecs for alloy types.
This can be done in two ways:

1. impl codecs in alloy directly
2. impl codecs in reth's codec crate

   reth/crates/storage/codecs/Cargo.toml

   Line 2 in 9569692

   name = "reth-codecs"

since codecs are a reth thing, we could pursue option 2.
This however, would require implementing codecs manually, because derive is not possible
we could also spin out codecs which is just the Compact trait to it's standalone repo and make it a feature in alloy (option 1.)

reth/crates/storage/codecs/src/lib.rs

Line 36 in 9569692

pub trait Compact: Sized {

wdyt @DaniPopes

Additional context

No response

[gakonst]

I'm open to either. I do think the Compact eth specific encoding is valuable (optimal / zero cost?) so if it's worth pulling out of reth we should do that.

[github-actions]

This issue is stale because it has been open for 21 days with no activity.

[ghost]

hi @mattsse, have we decided which direction we should take on this one. I think alloy can benefit from this codec, we should move the codecs to alloy and reuse it in reth.

[mattsse]

this should be integrated in the codecs crate for alloy-eips types
then replacing the duplicated reth-primitive types with alloy-eips

[ghost]

I can give it a try

[mattsse]

let's do this one by one, starting with:

• alloy-primitives::Log, replacing reth-primitives::Log
• then accesslist
• then withdrawals

we need compact codec tests from main, that we can use as test vectors for this

I think you can use cargo expand on main and copy the trait impl to get started

[ghost]

regarding the reth_codecs where should we spin it to a standalone one, maybe we create something like alloy/codecs, we need it to avoid circular deps while moving code around. Can you create the repo? @mattsse

[mattsse]

these should be implemented where the Compact trait is defined, we discarded the other option.
then there are no circular deps

we can feature gate this impls with like an alloy feature

does that make sense?

[ghost]

oh I see, this is definitely easier to implement. I thought we wanted to move the whole Compact to alloy, it's clear now.

[mattsse]

great!

I think we can move the impls in a new alloy.rs file here

reth/crates/storage/codecs/src/lib.rs

Line 18 in 57e25be

[ghost]

I will continue with Withdrawal, and AccessList then we can replace them in next PRs.

[mattsse]

cool! ty

separately, we can now replace the reth_primitive::Log type in a separate pr

[ghost]

Thanks @mattsse for replacing duplicate Withdrawl part, I was a bit busy.