Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Deduplicate consensus and rpc types AccessList #255

Closed
DaniPopes opened this issue Mar 8, 2024 · 6 comments · Fixed by #324
Closed

[Feature] Deduplicate consensus and rpc types AccessList #255

DaniPopes opened this issue Mar 8, 2024 · 6 comments · Fixed by #324
Assignees
Labels
enhancement New feature or request

Comments

@DaniPopes
Copy link
Member

Component

consensus, eips, genesis, network, json-rpc

Describe the feature you would like

pub struct AccessList(

pub struct AccessList(pub Vec<AccessListItem>);

Additional context

No response

@DaniPopes DaniPopes added the enhancement New feature or request label Mar 8, 2024
@mattsse
Copy link
Member

mattsse commented Mar 8, 2024

from reth POV I believe there's a similar problem with the Withdrawal type,

so I think we should find a way to extract the Withdrawal type from rpc and perhaps also move to eip crate or find a better location for these types that have the same representation in rpc and consensus

@sambacha
Copy link

Checking out the access list generation, it seems there are no checks against preventing that `tx sender`, `tx recipient`, `block producer`, created contracts and precompiles  should *not* be included in access lists as they are considered warm. Should I make a separate issue?

@DaniPopes
Copy link
Member Author

I don't fully understand your comment but that should definitely be in a different issue

@mattsse
Copy link
Member

mattsse commented Mar 12, 2024

from,to are excluded

https://github.com/paradigmxyz/evm-inspectors/blob/d7317c7fbf38d5e5df2393beee0414c987ea440a/src/access_list.rs#L31

@mattsse
Copy link
Member

mattsse commented Mar 15, 2024

AccessList+Withdrawals should be moved to eips crate

@JackG-eth
Copy link
Contributor

Happy to pick this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants