Skip to content

Commit

Permalink
feat: add is eip4844 fn (#4147)
Browse files Browse the repository at this point in the history
  • Loading branch information
mattsse authored Aug 10, 2023
1 parent b8b7ad6 commit e43187b
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 5 deletions.
2 changes: 1 addition & 1 deletion crates/primitives/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ pub use transaction::{
IntoRecoveredTransaction, InvalidTransactionError, Signature, Transaction, TransactionKind,
TransactionMeta, TransactionSigned, TransactionSignedEcRecovered, TransactionSignedNoHash,
TxEip1559, TxEip2930, TxEip4844, TxLegacy, TxType, EIP1559_TX_TYPE_ID, EIP2930_TX_TYPE_ID,
LEGACY_TX_TYPE_ID,
EIP4844_TX_TYPE_ID, LEGACY_TX_TYPE_ID,
};
pub use withdrawal::Withdrawal;

Expand Down
4 changes: 3 additions & 1 deletion crates/primitives/src/transaction/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ use reth_rlp::{
use serde::{Deserialize, Serialize};
pub use signature::Signature;
use std::mem;
pub use tx_type::{TxType, EIP1559_TX_TYPE_ID, EIP2930_TX_TYPE_ID, LEGACY_TX_TYPE_ID};
pub use tx_type::{
TxType, EIP1559_TX_TYPE_ID, EIP2930_TX_TYPE_ID, EIP4844_TX_TYPE_ID, LEGACY_TX_TYPE_ID,
};

pub use eip1559::TxEip1559;
pub use eip2930::TxEip2930;
Expand Down
3 changes: 1 addition & 2 deletions crates/primitives/src/transaction/tx_type.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ pub const EIP2930_TX_TYPE_ID: u8 = 1;
pub const EIP1559_TX_TYPE_ID: u8 = 2;

/// Identifier for [TxEip4844](crate::TxEip4844) transaction.
#[allow(unused)]
pub(crate) const EIP4844_TX_TYPE_ID: u8 = 3;
pub const EIP4844_TX_TYPE_ID: u8 = 3;

/// Transaction Type
///
Expand Down
8 changes: 7 additions & 1 deletion crates/transaction-pool/src/traits.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ use crate::{
use futures_util::{ready, Stream};
use reth_primitives::{
Address, FromRecoveredTransaction, IntoRecoveredTransaction, PeerId, Transaction,
TransactionKind, TransactionSignedEcRecovered, TxHash, EIP1559_TX_TYPE_ID, H256, U256,
TransactionKind, TransactionSignedEcRecovered, TxHash, EIP1559_TX_TYPE_ID, EIP4844_TX_TYPE_ID,
H256, U256,
};
use reth_rlp::Encodable;
use std::{
Expand Down Expand Up @@ -554,6 +555,11 @@ pub trait PoolTransaction:
self.tx_type() == EIP1559_TX_TYPE_ID
}

/// Returns true if the transaction is an EIP-4844 transaction.
fn is_eip4844(&self) -> bool {
self.tx_type() == EIP4844_TX_TYPE_ID
}

/// Returns the length of the rlp encoded object
fn encoded_length(&self) -> usize;

Expand Down

0 comments on commit e43187b

Please sign in to comment.